Labels Milestones

New Issue

Pictures for vec_sum2s, vec_sum4s, and vec_sums #26

Closed

opened 5 years ago by wschmidt-ibm · 8 comments

wschmidt-ibm commented 5 years ago (Migrated from github.com)

PC requests pictures for these.

PC requests pictures for these.

ThinkOpenly commented 5 years ago (Migrated from github.com)

• PDF
  • vec_sum2s
  • vec_sum4s
  • vec_sums
• web
  • vec_sum2s
  • vec_sum4s
  • vec_sums

* PDF * `vec_sum2s`  * `vec_sum4s`  * `vec_sums`  * web * `vec_sum2s`  * `vec_sum4s`  * `vec_sums` 

wschmidt-ibm commented 5 years ago (Migrated from github.com)

The second example for vec_sum4s gets saturation wrong, since this is signed arithmetic. The third column for r should say it is saturated, and the fourth column result should be 00000000.

The web version has the bullets located oddly with respect to the tables.

For vec_sums, b and r are in italics, rather than boldface.

Otherwise ok, please resubmit.

The second example for vec_sum4s gets saturation wrong, since this is signed arithmetic. The third column for **r** should say it is saturated, and the fourth column result should be 00000000. The web version has the bullets located oddly with respect to the tables. For vec_sums, **b** and **r** are in italics, rather than boldface. Otherwise ok, please resubmit.

wschmidt-ibm commented 5 years ago (Migrated from github.com)

I suppose the weird bullets are an artifact of github, not the examples themselves...

I suppose the weird bullets are an artifact of github, not the examples themselves...

ThinkOpenly commented 5 years ago (Migrated from github.com)

Those two columns in the vec_sum4s are indeed wrong. The fourth column should indeed be 00000000, but the 3rd column should actually be 7FFEFFFF because 8421 is negative. However, that's not what I intended, and curse me for not acutally writing and running a test.
I'll fix it up. I don't acutally like the 3rd column as a useful example.
I'll resubmit in a bit.

Those two columns in the `vec_sum4s` are indeed wrong. The fourth column should indeed be `00000000`, but the 3rd column should actually be `7FFEFFFF` because `8421` is negative. However, that's not what I intended, and curse me for not acutally writing and running a test. I'll fix it up. I don't acutally like the 3rd column as a useful example. I'll resubmit in a bit.

ThinkOpenly commented 5 years ago (Migrated from github.com)

Oh, the bullets are not part of the images. I put the images in a list in the GitHub comment. I have not done this before, but this commit hit multiple sections. I thought, mistakenly, that it would be clearer. :-/

Oh, the bullets are not part of the images. I put the images in a list in the GitHub comment. I have not done this before, but this commit hit multiple sections. I thought, mistakenly, that it would be clearer. :-/

ThinkOpenly commented 5 years ago (Migrated from github.com)

force pushed. ready for review again. sorry for the earlier noise. Here are updated images (differently formatted display this time):

• PDF
  • vec_sum2s

    

  • vec_sum4s

    

  • vec_sums

    

• web:
  • vec_sum2s

    

  • vec_sum4s

    

  • vec_sums

    

force pushed. ready for review again. sorry for the earlier noise. Here are updated images (differently formatted display this time): * PDF * `vec_sum2s` >  * `vec_sum4s` >  * `vec_sums` >  * web: * `vec_sum2s` >  * `vec_sum4s` >  * `vec_sums` > 

wschmidt-ibm commented 5 years ago (Migrated from github.com)

Looks good, with one nit. vec_sum2s is missing the horizontal line at the bottom of the frame, in both PDF and web versions. Can you please fix?

Looks good, with one nit. vec_sum2s is missing the horizontal line at the bottom of the frame, in both PDF and web versions. Can you please fix?

ThinkOpenly commented 5 years ago (Migrated from github.com)

Weird. I think my pictures were both coincidentally poorly captured, omitting the bottom border. Unless you built the changes and see the same thing, I think it was just a poor image capture. I've recaptured the images below:

Weird. I think my pictures were _both_ coincidentally poorly captured, omitting the bottom border. Unless you built the changes and see the same thing, I think it was just a poor image capture. I've recaptured the images below:  

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

v2

1.0.0-prd2

1.0.0-prd

1.0.0-prd3

v1.0.0

Labels

Apply labels

Clear labels   

bug

  

duplicate

  

enhancement

  

future

Deferred to a future release   

good first issue

  

help wanted

  

invalid

  

P1

Must be incorporated into next document publish   

P2

Desirable for incorporation into next document publish   

P3

Low priority for next document publish   

question

  

wontfix

No Label

bug

duplicate

enhancement

future

good first issue

help wanted

invalid

P1

P2

P3

question

wontfix

Milestone

Set milestone

Clear milestone

No items

No Milestone

Projects

Set Project

Clear projects

No project

Assignees

Assign users

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: systemsoftware/Programming-Guides#26

Write Preview

Loading…

Cancel

Save

There is no content yet.