Pictures for vec_sum2s, vec_sum4s, and vec_sums #26

Closed
opened 3 years ago by wschmidt-ibm · 8 comments
wschmidt-ibm commented 3 years ago (Migrated from github.com)
Owner

PC requests pictures for these.

PC requests pictures for these.
ThinkOpenly commented 3 years ago (Migrated from github.com)
Owner
  • PDF
    • vec_sum2s Screenshot from 2020-05-04 16-06-51
    • vec_sum4s Screenshot from 2020-05-04 16-07-16
    • vec_sums Screenshot from 2020-05-04 16-07-27
  • web
    • vec_sum2s Screenshot from 2020-05-04 16-07-54
    • vec_sum4s Screenshot from 2020-05-04 16-08-08
    • vec_sums Screenshot from 2020-05-04 16-08-28
* PDF * `vec_sum2s` ![Screenshot from 2020-05-04 16-06-51](https://user-images.githubusercontent.com/12301795/81013963-a7e3a380-8e21-11ea-97d3-b177a025a28f.png) * `vec_sum4s` ![Screenshot from 2020-05-04 16-07-16](https://user-images.githubusercontent.com/12301795/81013998-b92cb000-8e21-11ea-91fa-a7d5ec6fe04b.png) * `vec_sums` ![Screenshot from 2020-05-04 16-07-27](https://user-images.githubusercontent.com/12301795/81014005-bdf16400-8e21-11ea-93c1-4499b38ce8ae.png) * web * `vec_sum2s` ![Screenshot from 2020-05-04 16-07-54](https://user-images.githubusercontent.com/12301795/81014017-c184eb00-8e21-11ea-9380-674f2260cbcb.png) * `vec_sum4s` ![Screenshot from 2020-05-04 16-08-08](https://user-images.githubusercontent.com/12301795/81014024-c47fdb80-8e21-11ea-8d11-f8adf7be7d69.png) * `vec_sums` ![Screenshot from 2020-05-04 16-08-28](https://user-images.githubusercontent.com/12301795/81014038-c8abf900-8e21-11ea-99d8-54225e75d8d6.png)
wschmidt-ibm commented 3 years ago (Migrated from github.com)
Owner

The second example for vec_sum4s gets saturation wrong, since this is signed arithmetic. The third column for r should say it is saturated, and the fourth column result should be 00000000.

The web version has the bullets located oddly with respect to the tables.

For vec_sums, b and r are in italics, rather than boldface.

Otherwise ok, please resubmit.

The second example for vec_sum4s gets saturation wrong, since this is signed arithmetic. The third column for **r** should say it is saturated, and the fourth column result should be 00000000. The web version has the bullets located oddly with respect to the tables. For vec_sums, **b** and **r** are in italics, rather than boldface. Otherwise ok, please resubmit.
wschmidt-ibm commented 3 years ago (Migrated from github.com)
Owner

I suppose the weird bullets are an artifact of github, not the examples themselves...

I suppose the weird bullets are an artifact of github, not the examples themselves...
ThinkOpenly commented 3 years ago (Migrated from github.com)
Owner

Those two columns in the vec_sum4s are indeed wrong. The fourth column should indeed be 00000000, but the 3rd column should actually be 7FFEFFFF because 8421 is negative. However, that's not what I intended, and curse me for not acutally writing and running a test.
I'll fix it up. I don't acutally like the 3rd column as a useful example.
I'll resubmit in a bit.

Those two columns in the `vec_sum4s` are indeed wrong. The fourth column should indeed be `00000000`, but the 3rd column should actually be `7FFEFFFF` because `8421` is negative. However, that's not what I intended, and curse me for not acutally writing and running a test. I'll fix it up. I don't acutally like the 3rd column as a useful example. I'll resubmit in a bit.
ThinkOpenly commented 3 years ago (Migrated from github.com)
Owner

Oh, the bullets are not part of the images. I put the images in a list in the GitHub comment. I have not done this before, but this commit hit multiple sections. I thought, mistakenly, that it would be clearer. :-/

Oh, the bullets are not part of the images. I put the images in a list in the GitHub comment. I have not done this before, but this commit hit multiple sections. I thought, mistakenly, that it would be clearer. :-/
ThinkOpenly commented 3 years ago (Migrated from github.com)
Owner

force pushed. ready for review again. sorry for the earlier noise. Here are updated images (differently formatted display this time):

  • PDF
    • vec_sum2s

      Screenshot from 2020-05-04 18-44-39

    • vec_sum4s

      Screenshot from 2020-05-04 18-45-04

    • vec_sums

      Screenshot from 2020-05-04 18-45-21

  • web:
    • vec_sum2s

      Screenshot from 2020-05-04 18-45-54

    • vec_sum4s

      Screenshot from 2020-05-04 18-46-28

    • vec_sums

      Screenshot from 2020-05-04 18-46-45

force pushed. ready for review again. sorry for the earlier noise. Here are updated images (differently formatted display this time): * PDF * `vec_sum2s` > ![Screenshot from 2020-05-04 18-44-39](https://user-images.githubusercontent.com/12301795/81024001-ab822500-8e37-11ea-9039-6517c299c32f.png) * `vec_sum4s` > ![Screenshot from 2020-05-04 18-45-04](https://user-images.githubusercontent.com/12301795/81024007-afae4280-8e37-11ea-9148-3c4c761f1a7f.png) * `vec_sums` > ![Screenshot from 2020-05-04 18-45-21](https://user-images.githubusercontent.com/12301795/81024015-b341c980-8e37-11ea-83c3-6dab61e087eb.png) * web: * `vec_sum2s` > ![Screenshot from 2020-05-04 18-45-54](https://user-images.githubusercontent.com/12301795/81024021-b8067d80-8e37-11ea-94d4-00d997890c89.png) * `vec_sum4s` > ![Screenshot from 2020-05-04 18-46-28](https://user-images.githubusercontent.com/12301795/81024030-bfc62200-8e37-11ea-90f3-ef10bd4b99df.png) * `vec_sums` > ![Screenshot from 2020-05-04 18-46-45](https://user-images.githubusercontent.com/12301795/81024036-c5bc0300-8e37-11ea-900a-8a793d579c5e.png)
wschmidt-ibm commented 3 years ago (Migrated from github.com)
Owner

Looks good, with one nit. vec_sum2s is missing the horizontal line at the bottom of the frame, in both PDF and web versions. Can you please fix?

Looks good, with one nit. vec_sum2s is missing the horizontal line at the bottom of the frame, in both PDF and web versions. Can you please fix?
ThinkOpenly commented 3 years ago (Migrated from github.com)
Owner

Weird. I think my pictures were both coincidentally poorly captured, omitting the bottom border. Unless you built the changes and see the same thing, I think it was just a poor image capture. I've recaptured the images below:
Screenshot from 2020-05-04 21-35-41
Screenshot from 2020-05-04 21-36-08

Weird. I think my pictures were _both_ coincidentally poorly captured, omitting the bottom border. Unless you built the changes and see the same thing, I think it was just a poor image capture. I've recaptured the images below: ![Screenshot from 2020-05-04 21-35-41](https://user-images.githubusercontent.com/12301795/81030709-5baf5800-8e4f-11ea-8108-f5ff476e9a49.png) ![Screenshot from 2020-05-04 21-36-08](https://user-images.githubusercontent.com/12301795/81030728-75509f80-8e4f-11ea-81a8-da6babbb09d0.png)
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.