add homepage, header, footer, styles
#1
Closed
ryan.letbe-holder
wants to merge 0 commits from archetype-theme-transition
into master
Loading…
Reference in New Issue
There is no content yet.
Delete Branch 'archetype-theme-transition'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Hi @toshywoshy Here's the index page as a test of our workflow.
My aim, for speed, is to get the site complete with all content hard-coded, and then break the text/images out in the correct way to be updated with Hugo, so this page will be revisited.
Please leave the branch undeleted after merge, as I'll continue work in it.
Many thanks,
Ryan
I cannot merge this into master, as your current PR is based upon static replacements and would break the entire website.
This makes the website completely unusable as we only would see a single page, and doesn't allow any of the existing content to be displayed.
Also you're using static theme images for non-theme images, not optimizing them with the HugoIO functions.
You mentioned having scss based files, however I see you're just copying in another css file, which seems to be just the downloaded, non optimzed stylesheet
Hi @toshywoshy that's understood. As mentioned above, my primary concern was speed. However, after talking to the team today, the time pressure seems to be reduced. With this in mind, I'll do the aforementioned Hugo integrations now rather than later, and proceed one page at a time.
There is one thing that you've mentioned which I'd like clarity on (please excuse any simple questions, as I'm new to Hugo) - you said that merging this pull, we would only see a single page. I'm not sure why this would be. Indeed when I'm running my local branch via hugo server -D, I can still access the other pages, which have the same content as before (apart from the restyled header/footer). Can I rely on the site I see when running '$hugo server -D' to be a faithful representation of what will be shown on production? If not, what are the differences?
Many thanks,
Ryan
Hi @toshywoshy Adjustments have been made. Please check and let me know if there are any more outstanding issues here.
Merged into master after a rebase and manual adjustments