website
/
openpower.foundation
17
2
Fork 10
Code Issues 9 Pull Requests Releases Wiki Activity

Labels Milestones

Updates to OSU HUB Form, Update OSU logo, and other small changes #46

Merged
Toshaan Bharvani merged 8 commits from maxschmidt/openpower.foundation:master into master 3 years ago
Conversation 5 Commits 8 Files Changed 6
Maximillian Schmidt commented 3 years ago
There is no content yet.
Maximillian Schmidt commented 3 years ago
Poster

@toshywoshy any chance we can get this approved soon?

@toshywoshy any chance we can get this approved soon?
Lance Albertson requested changes 3 years ago
Lance Albertson left a comment
  • Please use optipng to optmize the png so that it's smaller. It's rather large for a website
  • Please remove any trailing white spaces
  • Update to current master branch
- [ ] Please use `optipng` to optmize the png so that it's smaller. It's rather large for a website - [ ] Please remove any trailing white spaces - [ ] Update to current master branch
Toshaan Bharvani commented 3 years ago
Owner
  • Please use optipng to optmize the png so that it's smaller. It's rather large for a website

We use HugoIO's image conversion tool, hugo-extended has this feature and we can therefor convert any image to webp and optimize it scaling and ratios according to the page.

  • Please remove any trailing white spaces

Yes, please, I should work out a lint checker.

  • Update to current master branch

Yes, sorry, I didn't see this PR early enough so rebase to latest and I can approve to master

> - [ ] Please use `optipng` to optmize the png so that it's smaller. It's rather large for a website We use HugoIO's image conversion tool, ```hugo-extended``` has this feature and we can therefor convert any image to webp and optimize it scaling and ratios according to the page. > - [ ] Please remove any trailing white spaces Yes, please, I should work out a lint checker. > - [ ] Update to current master branch Yes, sorry, I didn't see this PR early enough so rebase to latest and I can approve to master
Lance Albertson commented 3 years ago

Ideally a rebase instead of a merge when updating.

Ideally a rebase instead of a merge when updating.
Maximillian Schmidt force-pushed master from 8d41de3079 to 00bda9b212 3 years ago
Maximillian Schmidt requested review from Lance Albertson 3 years ago
Maximillian Schmidt changed title from Updates to OSU HUB Form and other small changes to Updates to OSU HUB Form, Add OSU HUB Blog, and other small changes 3 years ago
Toshaan Bharvani commented 3 years ago
Owner

Please create a seperate PR for the blog.
Without the blog, I can move to merge.

Please create a seperate PR for the blog. Without the blog, I can move to merge.
Maximillian Schmidt force-pushed master from db88fc5d68 to 29f3e2a774 3 years ago
Maximillian Schmidt changed title from Updates to OSU HUB Form, Add OSU HUB Blog, and other small changes to Updates to OSU HUB Form, Update OSU logo, and other small changes 3 years ago
Maximillian Schmidt commented 3 years ago
Poster

Well that wasn't right. Working on it.

Well that wasn't right. Working on it.
Maximillian Schmidt force-pushed master from 357206bb3f to 0c77a733e3 3 years ago
Toshaan Bharvani approved these changes 3 years ago
Toshaan Bharvani merged commit 9e4f5c909e into master 3 years ago

Reviewers

Lance Albertson was requested for review 3 years ago
Toshaan Bharvani approved these changes 3 years ago
The pull request has been merged as 9e4f5c909e.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Lance Albertson
Toshaan Bharvani
Labels
Apply labels
Clear labels   
Blog
   
Corrections
   
OPF Ready
   
OPF Resources
No Label
Blog
Corrections
OPF Ready
OPF Resources
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: website/openpower.foundation#46
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'maxschmidt/openpower.foundation:master'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes